Enforce CLM balance checks w/ DART

braczka commented 2 months ago

Description:

The CLM Sourcecode (ctsm_cesm2.2.03 run on Derecho), nor the current CLM-DART SourceMods allow for the CLM balance checks to be turned on after the DA time step. Balance checks are skipped for the entire simulation, which could mask important issues like model stability.

Fixes issue

Fixes issue #671

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Documentation changes needed?

No Doc changes needed. This is a capability that should have already been working, but apparently broke when updating the ctsm version to work with Derecho.

Tests

Ran the CLM-DART tutorial, and included print statements to confirm balance checks were being enforced after 1st time step after restart.

Checklist for merging

[ ] Updated changelog entry
[ ] Update conf.py

Checklist for release

[X] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[X] No dataset needed

braczka commented 2 months ago

Because these are SourceMod changes the file changes as part of this PR look huge because in some cases an entire file needs to be added. However actual changes compared to Source code are quite small. To look at differences compare with CLM Source Code version ctsm_cesm2.2.03. For example: /glade/work/bmraczka/ctsm_cesm2.2.03/

braczka commented 2 months ago

I would like to increase the capability of the SourceMod to allow the user to modify the number of steps to skip after DA. Currently it is fixed at 1 skipped time step for all balance checks including carbon, nitrogen, snow, water, radiation etc. Some users have found it convenient to skip multiple time steps (e.g. soil moisture DA).

braczka commented 2 months ago

Also posted issue in CTSM github https://github.com/ESCOMP/CTSM/issues/2525 to make them aware of bug for future releases, and also look for an easy, alternative fix.

NCAR / DART