on-demand GitHub action which runs every quickbuild.sh in DART

hkershaw-brown commented 2 weeks ago

Description:

On demand github action to run every quickbuild.sh in DART Uses container with dart dependencies hdfeos2, hdf4, hdf5, rttov12 Takes ~4 minutes

Fixes issue

Github version the build_everything developer tests https://github.com/NCAR/DART/pull/593

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Documentation changes needed?

[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.

Tests

Run the action on main branch of your fork.

Checklist for merging

[ ] Updated changelog entry
[ ] Documentation updated
[ ] Update conf.py

Checklist for release

[ ] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[ ] No dataset needed

hkershaw-brown commented 4 days ago

I'm kind of digging the failure as a mark of shame, but you're right you have to check the annotations. Do you think skipping the expected fails is ok (not run them in the matrix)?

Screenshot 2024-07-03 at 11 57 23 AM

mjs2369 commented 4 days ago

I'm kind of digging the failure as a mark of shame, but you're right you have to check the annotations. Do you think skipping the expected fails is ok (not run them in the matrix)?

@hkershaw-brown I think that sounds like a good plan. I'm just a little confused on how we would go about setting the expected fails to have them not run in the matrix? Just like how you are currently skipping the template model, but for the three failing obs converters instead?

for item in "${files_to_process[@]}"; do
            if [[ $item == *"template"* ]]; then
              continue  # template model not for compiling
            fi

Also side note is that GSI2DART compiles with the use of -fallow-argument-mismatch

hkershaw-brown commented 2 days ago

@hkershaw-brown I think that sounds like a good plan. I'm just a little confused on how we would go about setting the expected fails to have them not run in the matrix? Just like how you are currently skipping the template model, but for the three failing obs converters instead?
for item in "${files_to_process[@]}"; do
            if [[ $item == *"template"* ]]; then
              continue  # template model not for compiling
            fi

yup, just skip them.

hkershaw-brown commented 2 days ago

skipping known failures, using -fallow-argument-mismatch for GSI2DART 21399b953b12c444214436bc37a617ee5b2d809e

NCAR / DART