search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
196 stars 145 forks source link

Comment not clear #70

Closed hkershaw-brown closed 1 year ago

hkershaw-brown commented 3 years ago

https://github.com/NCAR/DART/blob/18106dd410462cc96478b7a634d7c8ec08fea060/assimilation_code/modules/assimilation/filter_mod.f90#L192

distributed_state = .true. is ensemble complete, correct?

nancycollins commented 3 years ago

the terminology is always confusing to me. inside the ensemble manager the terms are 'var complete' and 'copy complete'. in the filter context, i guess it would still be 'copy complete' (meaning each task has all copies of a subset of the state vector) and 'ensemble member complete' (each task has one or more entire state vectors). maybe we also use 'state complete' for that. but in any case that's not what this comment should be - it should be '... copy complete forward operators'.

(edited to be more clear, i hope. correct me if i'm remembering this backwards. i sure hope not!)

jlaucar commented 3 years ago

Maybe I'm confused, but isn't this the namelist that controls whether the single copy of the ensemble mean state is distributed across tasks or not. It is not directly related to copy complete or ensemble complete notions for the ensemble state. I don't have time to prove myself wrong by looking at the code at the moment.

nancycollins commented 3 years ago

this namelist item controls the ensemble behavior for the state. there is a different one for the mean.