Closed braczka closed 1 month ago
see the wrf model_mod refactor for not using model_mod types https://github.com/NCAR/DART/pull/683
Thanks @hkershaw-brown for including these references. Based on our group conversation today I will address this for now with better documentation to always use THM, not T -- and perhaps include a warning message when T is included in WRF state. This doesn't limit WRF-DART functionality, it only prohibits use of T variable. We can revisit discussion on wrf model_mod refactor later down the road.
fixed in #733
:bug:
Describe the bug
List the steps someone needs to take to reproduce the bug.
I ran into this while using
filter
with obs_def_rttov13.f90, however this error will occur during any process that uses the WRF model_mod.f90 and requires 'boundscheck' for forward operator calculationWhat was the expected outcome? It was expected that the WRF model_modf.90 would be able to interpolate the pressure variable while using 'T variable.
What actually happened?
Get error below, which is hard to interpret. Error is actually from boundscheck located here: https://github.com/NCAR/DART/blob/a85e162288a90da1fc1ed28fa4d80acb1ca80920/models/wrf/model_mod.f90#L2062
Error Message
Which model(s) are you working with?
WRF4.4
Version of DART
v11.6.0
Have you modified the DART code?
The fix is easy enough -- just replace T with THM and make sure WRF outputs THM. We encourage users to use THM and not T in the WRF documentation, however, it appears when using the WRF model_mod.f90 the code makes using THM mandatory, which is really an unintended side effect. The code should be able to use T or THM interchangeably when just used as a forward operator.
Note: The code isn't actually using 'T' or 'THM' to interpolate but using for a 'boundscheck' so not really sure if using 'type_t' is mandatory for this application.
At any rate the code throws a non-intuitive error and may be hard for casual user to intepret.
Build information
Derecho - intel compiler.