search

NCAR / DART

Data Assimilation Research Testbed
https://dart.ucar.edu/
Apache License 2.0
197 stars 145 forks source link

MPAS get_close_obs if vertical location is MISSING_R8 returns 0 close obs #758

Open hkershaw-brown opened 4 weeks ago

hkershaw-brown commented 4 weeks ago

Is this correct? What about observations with VERTISUNDEF?

https://github.com/NCAR/DART/blob/e2188646b97573f198c66f7ea63482ebc34afa11/models/mpas_atm/model_mod.f90#L1889-L1891

MISSING_R8 is an acceptable valur for vloc?

https://github.com/NCAR/DART/blob/e2188646b97573f198c66f7ea63482ebc34afa11/assimilation_code/location/threed_sphere/location_mod.f90#L906-L908

hkershaw-brown commented 4 weeks ago

similarly, distance calculation https://github.com/NCAR/DART/blob/e2188646b97573f198c66f7ea63482ebc34afa11/models/mpas_atm/model_mod.f90#L1939-L1940