Remove unused routine from normal_distribution_mod.f90 - Githubissues

NCAR / DART

Data Assimilation Research Testbed

https://dart.ucar.edu/

Apache License 2.0

197 stars 145 forks source link

Remove unused routine from normal_distribution_mod.f90 #763

Closed hkershaw-brown closed 2 weeks ago

hkershaw-brown commented 3 weeks ago

Description:

Removed unused routine from normal_distribution_mod.f90 Why?

we've had a couple of users be tripped up on this warning #6843 while troubleshooting other problems
broken windows, innit?

Fixes issue

fixes #736

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Documentation changes needed?

[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Build everything in DART on "unused-routine" branch: https://github.com/NCAR/DART/actions/runs/11613730959

note the GOES build fails because the container is linking to rttov12 not rttov13 (https://github.com/NCAR/DART-containers/issues/1).

Checklist for merging

[ ] Updated changelog entry
[ ] Documentation updated
[ ] Update conf.py

Checklist for release

[ ] Merge into main
[ ] Create release from the main branch with appropriate tag
[ ] Delete feature-branch

Testing Datasets

[ ] Dataset needed for testing available upon request
[ ] Dataset download instructions included
[x] No dataset needed