Closed hkershaw-brown closed 1 week ago
mpas, observation vertical conversion was using zGridFace rather than zGridCenter
Following the call tree, using oncenters always
convert_vertical_obs -> convert_vert_distrib case (VERTISHEIGHT) -> find_vert_indices -> find_vert_level(oncenters = true) case (VERTEIGHT) if (oncenters) -> find_height_bounds(zGridCenter)
fixes #524
Please describe any tests you ran to verify your changes.
Skipped the early return so an obs with VERTISHEIGHT gets converted to VERTISHEIGHT. https://github.com/NCAR/DART/compare/main...hkershaw-brown:DART:bug_524_reproducer see https://github.com/NCAR/DART/issues/524#issuecomment-2447818389 for results.
You can grab my one obs test from /glade/derecho/scratch/hkershaw/DART/Bugs/bug_524/runs_524
Description:
mpas, observation vertical conversion was using zGridFace rather than zGridCenter
Following the call tree, using oncenters always
Fixes issue
fixes #524
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Skipped the early return so an obs with VERTISHEIGHT gets converted to VERTISHEIGHT. https://github.com/NCAR/DART/compare/main...hkershaw-brown:DART:bug_524_reproducer see https://github.com/NCAR/DART/issues/524#issuecomment-2447818389 for results.
Checklist for merging
Checklist for release
Testing Datasets
You can grab my one obs test from /glade/derecho/scratch/hkershaw/DART/Bugs/bug_524/runs_524