search

NCAR / GMET

Gridded Meteorological Ensemble Tool
13 stars 10 forks source link

Add user option for number of stations to consider for regression #19

Closed anewman89 closed 4 years ago

anewman89 commented 4 years ago

This needs to be merged after pull request #18 is merged.

andywood commented 4 years ago

probably so - it's a minor comment. perhaps one could have a list of static and a list of dynamic predictors ...

On Tue, Jun 16, 2020 at 4:35 PM Andy Newman notifications@github.com wrote:

@anewman89 commented on this pull request.

In downscale/estimate_forcing_regression.f90 https://github.com/NCAR/GMET/pull/19#discussion_r441179968:

@@ -1,7 +1,7 @@ ! AWW-2016Jan, modifications to handle time subsetting and reduce mem alloc, and clean up ! renamed from estimate_precip; add also 'directory' var, changed some var names

-subroutine estimate_forcing_regression (nPredict, gen_sta_weights, sta_weight_name, nwp_input_list, & +subroutine estimate_forcing_regression (sta_limit, nPredict, gen_sta_weights, sta_weight_name, nwp_input_list, &

nPredict could be set based on the number of inputs the user specifies rather than having it in the config file. We should do that in another request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NCAR/GMET/pull/19#discussion_r441179968, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARPSWM4HLJKN5NQFJB3RW7XTLANCNFSM4N6YTTFA .

anewman89 commented 4 years ago

I need to close this PR and reevaluate. I may have mixed something up with the timing of this PR and #18.