NCAR / GPEP

GNU General Public License v3.0
9 stars 6 forks source link

Negative precipitation is generated by Random Forest, if POE is not specified. #11

Closed DaveCasson closed 8 months ago

DaveCasson commented 8 months ago

This issue can be replicated by extending the RF test case (cali2017) to produce ensembles.

If POE is not included, then the result precipitation fields have negative values.

I expect the problem is occuring in the prob_estimate_for_one_var function of probablistic estimation. Without the poe, the first if statement is not met.

I had tried adding a backtransformation under the perturb_estimates_general function call, but this did not appear to solve the issue.

guoqiang-tang commented 8 months ago

Hi Dave, thanks for reporting this issue. I will check the RF ensemble estimation.

andywood commented 8 months ago

Thanks -- just to clarify, what does it mean if POE is not included? Wouldn't POE always be included when generating ensembles?

On Wed, Feb 7, 2024 at 2:09 PM Guoqiang Tang @.***> wrote:

Hi Dave, thanks for reporting this issue. I will check the RF ensemble estimation.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/GPEP/issues/11#issuecomment-1932910165, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARKIUOMRC2N5TYSDNFDYSPURNAVCNFSM6AAAAABC427WLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSHEYTAMJWGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

DaveCasson commented 8 months ago

The following settings are required to avoid the issue.

target_vars_WithProbability = [ "prcp",] probability_thresholds = [ 0,]

Yes, the should be specified. In my case, building up the ensemble run led to it being missed, and needed to target the cause in the test case.

Without the settings, the negative precip values are produced. I had initially thought it was a lack of back transformation, but based on high precip values still produced, it seems to be a lower cutoff(?).

As the settings should have been specified, you could close on user error. But had communicated with Guoqiang, and wanted to raise the issue.

guoqiang-tang commented 8 months ago

Thanks for the discussion. The target_vars_WithProbability should be set for variables with occurrence features like precipitation and snow. I'll close this issue