NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
3 stars 20 forks source link

Add the Stokes Forces Implementation for the Surface Bands wave coupling method #205

Closed alperaltuntas closed 2 years ago

alperaltuntas commented 2 years ago

This PR adds the Stokes Forces implementation by @breichl and some additional refactoring and bug fixes.

The summary of Stokes Forces changes (@breichl):

The summary of refactorings and bugfixes (@alperaltuntas) :

codecov-commenter commented 2 years ago

Codecov Report

Merging #205 (4f592f2) into dev/ncar (3d86e71) will decrease coverage by 0.05%. The diff coverage is 12.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/ncar     #205      +/-   ##
============================================
- Coverage     29.06%   29.01%   -0.06%     
============================================
  Files           237      237              
  Lines         71635    71842     +207     
============================================
+ Hits          20822    20845      +23     
- Misses        50813    50997     +184     
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_CVMix_KPP.F90 1.00% <0.00%> (ø)
src/user/MOM_wave_interface.F90 1.50% <5.19%> (+0.66%) :arrow_up:
src/core/MOM_dynamics_split_RK2.F90 59.46% <16.66%> (-1.62%) :arrow_down:
src/core/MOM_forcing_type.F90 47.25% <25.00%> (+0.02%) :arrow_up:
src/core/MOM.F90 58.88% <27.27%> (-0.13%) :arrow_down:
src/core/MOM_CoriolisAdv.F90 38.30% <28.26%> (-0.97%) :arrow_down:
config_src/drivers/solo_driver/MOM_driver.F90 68.20% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d86e71...4f592f2. Read the comment docs.

alperaltuntas commented 2 years ago

@gustavo-marques this is ready to be tested and merged.

gustavo-marques commented 2 years ago

@alperaltuntas, I have verified that this PR does not change answers for the MOM6-examples test suit w.r.t. the latest main (https://github.com/NCAR/MOM6/commit/9cb93044ef06a929171b5bd326a7c5c06aa72316). Were you able to run the CESM tests?

alperaltuntas commented 2 years ago

@gustavo-marques Yes, the aux_mom test suite passes.