NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
3 stars 20 forks source link

Improvements in the gradient Ri # calculation/diagnosis (MOM_CVMix_shear) #225

Closed gustavo-marques closed 2 years ago

gustavo-marques commented 2 years ago

This PR adds the following improvements in the calculation and diagnosis of the gradient Richardson number in the MOM_CVMix_shear module:

To recover previous answers, SMOOTH_RI = True must be replaced by N_SMOOTH_RI = 1. I verified that this PR does not change answers for GMOM/JRA.

codecov-commenter commented 2 years ago

Codecov Report

Base: 37.22% // Head: 37.22% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (b444041) compared to base (fe3cb4d). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/ncar #225 +/- ## ============================================ - Coverage 37.22% 37.22% -0.01% ============================================ Files 261 261 Lines 72319 72323 +4 Branches 13533 13534 +1 ============================================ Hits 26921 26921 - Misses 40407 40411 +4 Partials 4991 4991 ``` | [Impacted Files](https://codecov.io/gh/NCAR/MOM6/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) | Coverage Δ | | |---|---|---| | [src/parameterizations/vertical/MOM\_CVMix\_shear.F90](https://codecov.io/gh/NCAR/MOM6/pull/225/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3BhcmFtZXRlcml6YXRpb25zL3ZlcnRpY2FsL01PTV9DVk1peF9zaGVhci5GOTA=) | `11.11% <0.00%> (-0.37%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.