NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
2 stars 19 forks source link

(*) CFC_cap forcing update #236

Closed klindsay28 closed 1 year ago

klindsay28 commented 1 year ago

read atm CFC hemispheric aveages from CFC_BC_FILE, instead of 2D fields this changes CFC results

correct bug that atm cfc11 was used in cfc12 flux computation this changes CFC12 results

add CFC_BC_year_offset, converts model time to time in CFC_BC_file 2 new parameters: CFC_BC_DATA_YEAR, CFC_BC_MODEL_YEAR enables runs with CFC_cap to have model time different from CFC_BC_file time

PR must be paired with https://github.com/ESCOMP/MOM_interface/pull/132

failures from aux_mom cheyenne_intel: NLCOMP failures for all tests changed CFC_BC_FILE value from MOM_interface PR diag_table differs from baseline, but appears to be because of diff in casename in diag_table BASELINE failure for DIMCS_Ld1.TL319_t061.GMOM_JRA.cheyenne_intel.mom-cfc_mods--mom-debug expected answer change

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (9786710) 37.19% compared to head (4af003f) 37.19%.

:exclamation: Current head 4af003f differs from pull request most recent head 3a52e42. Consider uploading reports for the commit 3a52e42 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/ncar #236 +/- ## ============================================ - Coverage 37.19% 37.19% -0.01% ============================================ Files 263 263 Lines 73147 73163 +16 Branches 13625 13625 ============================================ + Hits 27209 27210 +1 - Misses 40927 40942 +15 Partials 5011 5011 ``` | [Impacted Files](https://codecov.io/gh/NCAR/MOM6/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) | Coverage Δ | | |---|---|---| | [src/tracer/MOM\_CFC\_cap.F90](https://codecov.io/gh/NCAR/MOM6/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fQ0ZDX2NhcC5GOTA=) | `16.58% <0.00%> (-1.45%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/NCAR/MOM6/pull/236/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alperaltuntas commented 1 year ago

@klindsay28 Are these PRs ready for review?

klindsay28 commented 1 year ago

Yes, they are ready for review.