Closed klindsay28 closed 1 year ago
Patch coverage has no change and project coverage change: -0.01
:warning:
Comparison is base (
9786710
) 37.19% compared to head (4af003f
) 37.19%.:exclamation: Current head 4af003f differs from pull request most recent head 3a52e42. Consider uploading reports for the commit 3a52e42 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@klindsay28 Are these PRs ready for review?
Yes, they are ready for review.
read atm CFC hemispheric aveages from CFC_BC_FILE, instead of 2D fields this changes CFC results
correct bug that atm cfc11 was used in cfc12 flux computation this changes CFC12 results
add CFC_BC_year_offset, converts model time to time in CFC_BC_file 2 new parameters: CFC_BC_DATA_YEAR, CFC_BC_MODEL_YEAR enables runs with CFC_cap to have model time different from CFC_BC_file time
PR must be paired with https://github.com/ESCOMP/MOM_interface/pull/132
failures from aux_mom cheyenne_intel: NLCOMP failures for all tests changed CFC_BC_FILE value from MOM_interface PR diag_table differs from baseline, but appears to be because of diff in casename in diag_table BASELINE failure for DIMCS_Ld1.TL319_t061.GMOM_JRA.cheyenne_intel.mom-cfc_mods--mom-debug expected answer change