NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
2 stars 18 forks source link

Improvements in the MOM_lateral_boundary_diffusion module #240

Closed gustavo-marques closed 1 year ago

gustavo-marques commented 1 year ago

This PR addresses comments from the reviewers of Marques et al. submitted to JAMES. This PR must be evaluated with https://github.com/ESCOMP/MOM_interface/pull/136 All solutions are bitwise identical.

Rename module

Reduce computational cost

Build and store the HBD grid outside the tracer loop since the same grid is used in all tracers. This reduces the computational cost of this module. A GMOM case run for 10 days with 3 tracers is ~ 7.5 % faster.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 29.91% and project coverage change: -0.01 :warning:

Comparison is base (72e5535) 37.18% compared to head (23e1794) 37.18%.

:exclamation: Current head 23e1794 differs from pull request most recent head a697159. Consider uploading reports for the commit a697159 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/ncar #240 +/- ## ============================================ - Coverage 37.18% 37.18% -0.01% ============================================ Files 263 263 Lines 73163 73219 +56 Branches 13625 13629 +4 ============================================ + Hits 27208 27223 +15 - Misses 40943 40984 +41 Partials 5012 5012 ``` | [Impacted Files](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) | Coverage Δ | | |---|---|---| | [src/core/MOM\_unit\_tests.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL2NvcmUvTU9NX3VuaXRfdGVzdHMuRjkw) | `16.66% <ø> (ø)` | | | [src/tracer/MOM\_neutral\_diffusion.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fbmV1dHJhbF9kaWZmdXNpb24uRjkw) | `65.38% <ø> (ø)` | | | [src/tracer/MOM\_tracer\_types.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fdHJhY2VyX3R5cGVzLkY5MA==) | `0.00% <ø> (ø)` | | | [src/tracer/MOM\_tracer\_hor\_diff.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fdHJhY2VyX2hvcl9kaWZmLkY5MA==) | `76.51% <25.00%> (+0.03%)` | :arrow_up: | | [src/tracer/MOM\_hor\_bnd\_diffusion.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01faG9yX2JuZF9kaWZmdXNpb24uRjkw) | `61.87% <29.41%> (ø)` | | | [src/tracer/MOM\_tracer\_registry.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fdHJhY2VyX3JlZ2lzdHJ5LkY5MA==) | `64.72% <33.33%> (+0.18%)` | :arrow_up: | | [src/diagnostics/MOM\_obsolete\_params.F90](https://codecov.io/gh/NCAR/MOM6/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL2RpYWdub3N0aWNzL01PTV9vYnNvbGV0ZV9wYXJhbXMuRjkw) | `69.66% <100.00%> (+0.34%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/NCAR/MOM6/pull/240/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.