Closed alperaltuntas closed 1 year ago
Patch coverage: 31.49
% and project coverage change: +1.30
:tada:
Comparison is base (
59cc9ed
) 35.88% compared to head (7344fcd
) 37.18%.:exclamation: Current head 7344fcd differs from pull request most recent head fb10ddc. Consider uploading reports for the commit fb10ddc to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The changes to MOM and the FMS infra should be fine. I have a pending PR which removes the references to fms_io_mod
in the FMS2 ensemble manager, but that conflict should not be difficult to resolve when it happens.
(I would suggest looking into squashing and rebasing some of these commits though!)
I ran an 8 instance case with this, looks good.
@gustavo-marques , I just realized there is a conflict due to the latest PR merge. I'll address that.
@gustavo-marques this is ready to merge. You can squash and merge. To run with multiple instances you can set ./xmlchange NINST_OCN=N
where N is the number of MOM6 instances you'd like to run with.
This PR introduces changes that are mainly in NUOPC cap, infra/FMS, and src/framework to accommodate multi-instance runs in CESM:
Changes in nuopc cap:
ensemble_manager_init
. This makes sure the input/output files contain the instance suffix.Changes in infra/FMS{1,2}:
ensumble_suffix
arg toensemble_manager_init
. If provided, this arg bypasses the call toFMS_ensemble_manager_init
, and instead, callsfms_io_set_filename_appendix
andfms2_io_set_filename_appendix
. This makes sure that all i/o files managed my FMS contains the ensemble suffix.Change in src/framework:
This PR should be evaluating in conjunction with https://github.com/ESCOMP/MOM_interface/pull/137.
I am mentioning @MJHarrison-GFDL, @marshallward, and @hkershaw-brown in case they'd prefer to review this PR before it gets merged to dev/ncar. If so, please let us know and will hold off until you review.