search

NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
3 stars 20 forks source link

Option to taper neutral diffusion #248

Closed gustavo-marques closed 1 year ago

gustavo-marques commented 1 year ago

Adds the option to apply a linear decay in the neutral diffusion fluxes within a transition zone defined by the boundary layer depths of adjacent columns, as in Fig. 2a from Marques et al., (2023). This option is controlled by a new parameter NDIFF_TAPERING, which is only available when NDIFF_INTERIOR_ONLY=True. By default, NDIFF_TAPERING=False, and answers are bitwise identical.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 9.37% and project coverage change: -0.04% :warning:

Comparison is base (aa58724) 37.07% compared to head (3cfe1fe) 37.04%. Report is 2 commits behind head on dev/ncar.

:exclamation: Current head 3cfe1fe differs from pull request most recent head cf29f1b. Consider uploading reports for the commit cf29f1b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/ncar #248 +/- ## ============================================ - Coverage 37.07% 37.04% -0.04% ============================================ Files 264 264 Lines 74421 74475 +54 Branches 13780 13787 +7 ============================================ - Hits 27592 27589 -3 - Misses 41739 41791 +52 - Partials 5090 5095 +5 ``` | [Files Changed](https://app.codecov.io/gh/NCAR/MOM6/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) | Coverage Δ | | |---|---|---| | [src/parameterizations/vertical/MOM\_CVMix\_KPP.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3BhcmFtZXRlcml6YXRpb25zL3ZlcnRpY2FsL01PTV9DVk1peF9LUFAuRjkw) | `0.75% <0.00%> (-0.03%)` | :arrow_down: | | [src/tracer/MOM\_neutral\_diffusion.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3RyYWNlci9NT01fbmV1dHJhbF9kaWZmdXNpb24uRjkw) | `63.36% <12.24%> (-2.03%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/NCAR/MOM6/pull/248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gustavo-marques commented 1 year ago

@alperaltuntas; this PR is ready for review.

alperaltuntas commented 1 year ago

LGTM. Did you run the test sute?

gustavo-marques commented 1 year ago

I did not test the entire suit, only GMOM JRA. I can do it now or we can do it once I create a follow-up PR adding the vertical structure in KHTR.

gustavo-marques commented 1 year ago

This PR is ready for review.