search

NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
2 stars 18 forks source link

Pass wavebands from coupler to wave_parameters_CS #255

Closed gustavo-marques closed 10 months ago

gustavo-marques commented 10 months ago

On behalf of Bill Large.

This commit passes the waveband information received from the coupler to wave_parameters_CS. This information is set to public so that it can be used elsewhere. To exercise this code the following must be set:

SURFBAND = COUPLER WAVE_METHOD = SURFACE_BANDS

No answer changes.

gustavo-marques commented 10 months ago

Please evaluate https://github.com/NCAR/MOM6/pull/256 before this PR.

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage: 3.94% and project coverage change: -0.14% :warning:

Comparison is base (d4aa108) 38.04% compared to head (48913da) 37.90%.

:exclamation: Current head 48913da differs from pull request most recent head 4cd7e8f. Consider uploading reports for the commit 4cd7e8f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/ncar #255 +/- ## ============================================ - Coverage 38.04% 37.90% -0.14% ============================================ Files 269 269 Lines 76872 77176 +304 Branches 14125 14170 +45 ============================================ + Hits 29243 29256 +13 - Misses 42356 42641 +285 - Partials 5273 5279 +6 ``` | [Files Changed](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR) | Coverage Δ | | |---|---|---| | [...c/parameterizations/vertical/MOM\_set\_viscosity.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3BhcmFtZXRlcml6YXRpb25zL3ZlcnRpY2FsL01PTV9zZXRfdmlzY29zaXR5LkY5MA==) | `60.98% <ø> (ø)` | | | [src/user/MOM\_wave\_interface.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3VzZXIvTU9NX3dhdmVfaW50ZXJmYWNlLkY5MA==) | `1.22% <0.00%> (-0.03%)` | :arrow_down: | | [...c/parameterizations/vertical/MOM\_vert\_friction.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL3BhcmFtZXRlcml6YXRpb25zL3ZlcnRpY2FsL01PTV92ZXJ0X2ZyaWN0aW9uLkY5MA==) | `48.64% <2.86%> (-9.95%)` | :arrow_down: | | [src/core/MOM\_forcing\_type.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL2NvcmUvTU9NX2ZvcmNpbmdfdHlwZS5GOTA=) | `41.99% <9.09%> (-0.26%)` | :arrow_down: | | [src/core/MOM\_dynamics\_split\_RK2.F90](https://app.codecov.io/gh/NCAR/MOM6/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR#diff-c3JjL2NvcmUvTU9NX2R5bmFtaWNzX3NwbGl0X1JLMi5GOTA=) | `62.01% <10.81%> (-2.80%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/NCAR/MOM6/pull/255/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NCAR)

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.