codecov-commenter
commented
8 months ago Codecov Report
Attention: Patch coverage is 30.00000% with 14 lines in your changes are missing coverage. Please review.
Project coverage is 37.40%. Comparing base (
13fbeb7) to head (a538cc0).:exclamation: Current head a538cc0 differs from pull request most recent head de59adf. Consider uploading reports for the commit de59adf to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev/ncar-candidate-240319 #272 +/- ## ============================================================= - Coverage 37.40% 37.40% -0.01% ============================================================= Files 270 270 Lines 79908 79914 +6 Branches 14858 14860 +2 ============================================================= + Hits 29893 29894 +1 - Misses 44469 44471 +2 - Partials 5546 5549 +3 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This commit makes the
unit_scale_typeargumentUStoMOM_domains_init()andgen_auto_mask_table()optional and moves it to the end of the argument list, so that coupled or ice-ocean models using SIS2 will compile with the proposed updates to the main branch of MOM6 from dev/ncar. Because MOM6 and SIS2 use some common framework code but are managed in separate github repositories, we need to use optional argument to allow a single version of SIS2 to work across changes to MOM6 interfaces. Because theTOPO_CONFIGparameter as used in SIS2 has a default value, there is an alternative call toget_param()forTOPO_CONFIGwith a default whenMOM_domains_init()is called with a domain_name argument. Also added missing scale arguments toget_param()calls forMINIMUM_DEPTHandMASKING_DEPTH. This commit also adds or corrects units in the comments describing 4 recently added or modified variables. All answers are bitwise identical in any cases that worked before (noting that some cases using SIS2 would not even compile before this fix).