search

NCAR / MOM6

NCAR/CESM fork of the Modular Ocean Model v.6 (MOM6)
Other
3 stars 20 forks source link

KE-conserving velocity remap dimensional consistency #307

Closed iangrooms closed 1 month ago

iangrooms commented 1 month ago

The dimensional consistency tests were failing with the old code because of the presence of a literal constant on these lines. I replaced those lines by logic to avoid divide-by-zero, and the new code passes the dimensional consistency test. I also cleaned up the unit scaling to make it more easily legible.

iangrooms commented 1 month ago

I created a new PR that is cleaner to merge, so I am deleting this one.