NCAR / MPAS-Workflow

Scripts for controlling DA workflows with MPAS-Model and mpas-bundle
Apache License 2.0
20 stars 15 forks source link

Fix the issue that first background files are in double precession while mpas-bundle in single-precession. #298

Closed mos3r3n closed 3 months ago

mos3r3n commented 7 months ago

Description

Our mpas-bundle is commonly built in single precession. However, the first background files are in double precession (i.e. ensemble background at 00Z 15 April 2018). In that case, the analysis output will report error information "ERROR: MPAS IO Error: Inconsistent redefinition of dimension" (@RGNystrom reported). To solve this issue, the NCO is employed to convert double (float) variables to float (double) variables when the mpas-bundle is built in single (double) precision.

Tests completed

Tier 1:

jim-p-w commented 7 months ago

Instead of converting the files on the fly every time this step is run would it be more efficient to convert the files once, and then use the appropriate files based on bundlePrecision?

liujake commented 7 months ago

@jim-p-w has a good point. It is better to simply convert files offline once, then use them in the workflow, e.g., replace the old double-precision file location with the new single-precision file location.

mos3r3n commented 7 months ago

That's right. Since we now use single-precision mpas-bundle only, it would be better that we prepare these files in single-precession rather than converting them when running workflow. @jim-p-w @liujake

liujake commented 7 months ago

@mos3r3n You can still use this PR, but fixing this in a different way: provide new location of the first cycle ensemble background files.

liujake commented 3 months ago

I think this one can be closed. @mos3r3n . We should have addressed this by converting double precision first background to single precision outside the workflow.