NCAR / MPAS-Workflow

Scripts for controlling DA workflows with MPAS-Model and mpas-bundle
Apache License 2.0
20 stars 15 forks source link

EnsembleOfVariational.csh file cleanup needs adjusting #309

Open jim-p-w opened 5 months ago

jim-p-w commented 5 months ago

The file removal needs to be more restrictive: https://github.com/NCAR/MPAS-Workflow/blob/41d50adb25f84e95bdb7e2b2202ec1c84a01d352/bin/EnsembleOfVariational.csh#L129C10-L129C35

Each instance of this job will remove all of the output files. The job must only remove the output files for the ensemble members the script is executing, e.g. if there are 12 ensemble members and EDASize is 3, then there will be 4 jobs (nDAInstances=4)

job 1 will handle members 1-3, job 2 will handle members 4-6, etc.

Also, the check for $MicrophysicsOuter should be protected by if ( $?MicrophysicsOuter ) then to ensure the variable is set before dereferencing it. https://github.com/NCAR/MPAS-Workflow/blob/41d50adb25f84e95bdb7e2b2202ec1c84a01d352/bin/EnsembleOfVariational.csh#L97