NCAR / ParallelIO

A high-level Parallel I/O Library for structured grid applications
Apache License 2.0
134 stars 52 forks source link

fails to build with mpich 4.0.1 #1912

Closed jedwards4b closed 2 years ago

jedwards4b commented 2 years ago

Using gcc 9 and mpich 4.0.1 generates errors in build.

jedwards4b commented 2 years ago

the issue is that variable MPI_OFFSET seems to be redefined.

jedwards4b commented 2 years ago

The problem is with the code in pio_internal.h:

#ifndef MPI_Offset
/** This is the type used for PIO_Offset. */
#define MPI_Offset long long
#endif

MPI_Offset is in mpi.h as:

typedef long MPI_Offset;

But for some reason the Macro resolves to false and redefines as long long.

jedwards4b commented 2 years ago

@edhartnett I am inclined to just remove this code - can you remind me of why we need it?

edwardhartnett commented 2 years ago

Remove it and if everything works, great.

I cannot remember the reasons for this, I'm afraid. It was a long time ago!