search

NCAR / ParallelIO

A high-level Parallel I/O Library for structured grid applications
Apache License 2.0
134 stars 52 forks source link

Incorrect minimum supported CMake version #1919

Closed ckhroulev closed 2 years ago

ckhroulev commented 2 years ago

cmake_minimum_required (VERSION 2.8.12) in CMakeLists.txt appears to be wrong: src/clib/CMakeLists.txt uses string(APPEND ...), which was added in CMake 3.4 (see https://cmake.org/cmake/help/v3.4/command/string.html).

jedwards4b commented 2 years ago

Thanks for pointing this out. I have changed the minimum version to 3.9.1 based on the oldest version I have easy access to and can test.

ckhroulev commented 2 years ago

@jedwards4b Thanks!