search

NCAR / ParallelIO

A high-level Parallel I/O Library for structured grid applications
Apache License 2.0
134 stars 52 forks source link

Fix default value of mode for PIO_openfile #1944

Closed billsacks closed 1 year ago

billsacks commented 1 year ago

Resolves NCAR/ParallelIO#1943. See that issue for details.

jedwards4b commented 1 year ago

@edwardhartnett These tests are failing because the github platform is using a newer version of gfortran which requires flag -fallow-argument-mismatch, I have added this flag in the cmake build, but I'm not sure how to do it for configure. There is some discussion in the mpich repo here. but I can find nothing in autoconf on the issue. Can you have a look?

jedwards4b commented 1 year ago

@sacks I have a fix for the failing github tests - would you allow me to push to your branch?

billsacks commented 1 year ago

Thanks @jedwards4b . Yes, please feel free to push to my branch. I think you should have permissions already, but let me know if you don't.

billsacks commented 1 year ago

The user who was having a permissions problem in her run confirmed that the changes in this PR fixed her issue.

jedwards4b commented 1 year ago

Thanks for the update, I am still working on straightening out the github actions.