search

NCAR / VAPOR

VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers
https://www.vapor.ucar.edu/
BSD 3-Clause "New" or "Revised" License
179 stars 49 forks source link

Add seed identifier to streamline/pathline output files #1979

Closed clyne closed 4 years ago

clyne commented 4 years ago

The flowline output format of the Flow visualizer does not contain a seed identifier. Having one would greatly facilitate automatic parsing of the file.

shaomeng commented 4 years ago

The current output file simply uses blocks separated by two empty lines to indicate separate pathlines. Do you mean we put add a comment-style description, for example a seed ID, in those two empty lines?

clyne commented 4 years ago

I was thinking of adding a column that has the seed ID, but for each single streamline (or pathline) you could have a header with the ID and Count (number of steps for each seed). The idea is simply to make it easy to build a tool parse the data automatically.

shaomeng commented 4 years ago

Well, the current output is able to be parsed for sure. We can definitely make it easier to be parsed, but the requirement needs to be more specific.

On Fri, Dec 13, 2019 at 3:52 PM clyne notifications@github.com wrote:

I was thinking of adding a column that has the seed ID, but for each single streamline (or pathline) you could have a header with the ID and Count (number of steps for each seed). The idea is simply to make it easy to build a tool parse the data automatically.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NCAR/VAPOR/issues/1979?email_source=notifications&email_token=AAGG6JMT7EZE5GO7JF43QOLQYQG3XA5CNFSM4JZFF572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3PPJA#issuecomment-565639076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGG6JMAPDFHPSSSUX3GWZ3QYQG3XANCNFSM4JZFF57Q .

clyne commented 4 years ago

Here's the requirement: Insert a column at the beginning that contains the flowline identifier (an integer with the first ID == 0). This will facilitate visual inspection of the file

shaomeng commented 4 years ago

This specific requirement means there will be a great amount of duplication:

Imagine one flow line that comprises 100 positions. Each of those positions is stored as one line in the current output. If this requirement is implemented, the ID will be duplicated for 100 times.

How about we consider another approach:

Before outputting this block of 100 lines, we insert one single line that states that all positions below belong to a streamline of ID = XXX.

What do you think?

On Fri, Dec 13, 2019 at 4:11 PM clyne notifications@github.com wrote:

Here's the requirement: Insert a column at the beginning that contains the flowline identifier (an integer with the first ID == 0). This will facilitate visual inspection of the file

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NCAR/VAPOR/issues/1979?email_source=notifications&email_token=AAGG6JJ4BC75LTWIN4IBGQTQYQJCRA5CNFSM4JZFF572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3Q2IY#issuecomment-565644579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGG6JOJ7QDVKUOM3P4VKQLQYQJCRANCNFSM4JZFF57Q .

shaomeng commented 4 years ago

Hmm, this requirement seems to be met already. Could @clyne verify?

clyne commented 4 years ago

It does indeed have an ID. However, the overall goal of this PR was to make it easier to automatically parse the outputs; the current line spaces between different seed identifiers make the outputs easier to read but more difficult to parse. Consider trying to import this output into a spreadsheet as a CSV file and then having to deal with all of the blank lines.

shaomeng commented 4 years ago

So to make sure, based on the current state of the program, the objective is to remove empty lines between groups of particles, is it right?

clyne commented 4 years ago

It looks to me like that is all that needs to be done, but I've not tried to import it as a CSV file.

clyne commented 4 years ago

@shaomeng shouldn't this be closed?

shaomeng commented 4 years ago

yeah, I think so

On Mon, Nov 9, 2020 at 7:14 PM clyne notifications@github.com wrote:

@shaomeng https://github.com/shaomeng shouldn't this be closed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/VAPOR/issues/1979#issuecomment-724404379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGG6JLCZPZMMQ6XZKFAETTSPCOXZANCNFSM4JZFF57Q .

clyne commented 4 years ago

yeah, I think so … On Mon, Nov 9, 2020 at 7:14 PM clyne @.***> wrote: @shaomeng https://github.com/shaomeng shouldn't this be closed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1979 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGG6JLCZPZMMQ6XZKFAETTSPCOXZANCNFSM4JZFF57Q .

Cool. Please be sure to put "Fixes <#PR>", "Closes...", etc. in the PR so that the associated issue is closed automatically by GitHub. Thanks.