search

NCAR / VAPOR

VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers
https://www.vapor.ucar.edu/
Other
177 stars 49 forks source link

Support for proj 8.X #3536

Open opoplawski opened 5 months ago

opoplawski commented 5 months ago

Describe the bug

Building vapor 4.9.1 on EL9 fails with:

In file included from /usr/include/libgeotiff/geo_keyp.h:18,
                 from /builddir/build/BUILD/VAPOR-3.9.1/apps/tiff2geotiff/tiff2geotiff.cpp:38:
/usr/include/proj.h:123:4: error: #error "The proj_api.h header has been removed from PROJ with version 8.0.0"
  123 |   #error "The proj_api.h header has been removed from PROJ with version 8.0.0"
      |    ^~~~~
/builddir/build/BUILD/VAPOR-3.9.1/apps/tiff2geotiff/tiff2geotiff.cpp:41:14: fatal error: proj_api.h: No such file or directory
   41 |     #include "proj_api.h"
      |              ^~~~~~~~~~~~
compilation terminated.

This is with proj 8.2.0.

Helpful additional information Impact

Expected behavior

vapor compiles fine.

sgpearse commented 5 months ago

Hi Orion, would you be able to try building with Proj 7.2.1?

opoplawski commented 5 months ago

8.2.0 is what is provided by EPEL, and I really don't want to stray from that. Proj 8.0 was released 3 years ago - I don't think it's unreasonable that it should be supported.

There is a migration guide: https://proj.org/en/9.3/development/migration.html#api-migration

which will work with proj 6+.

sgpearse commented 4 months ago

@opoplawski - We are currently trying to distribute a universal linux installer. Are you just trying to just install VAPOR on your systems, or are you trying to compile it for other needs? We can better assess upgrading PROJ based on what you're trying to accomplish.