UnstructuredGrid2D broken

NCAR / VAPOR

VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers

https://www.vapor.ucar.edu/

Other

173 stars 49 forks source link

Closed sgpearse closed 2 months ago

sgpearse commented 2 months ago

To reproduce:

1) import the MPAS file in /glade/p/cisl/vast/vapor/data/Source/MPAS/FalkoJudt/30km/*

Vapor will crash. This is also causing our smoke tests to fail.

NihanthCW commented 2 months ago

@StasJ will investigate and reassign to Sam if needed.

sgpearse commented 2 months ago

Note: The fix_ptr_cache PR broke the smoke tests for the same reasons in UnstructuredGrid2D.

shaomeng commented 2 months ago

The crash is because of the failure of this assertion: https://github.com/NCAR/VAPOR/blob/d25aaf05637d960f8ca942879627bfc427dccd47/lib/vdc/UnstructuredGrid.cpp#L29 where the vertex dims are reported to be 2, and edge dims are reported to be 1.

I think this disagreement between queried dimensions really needs some intervention from @StasJ .