search

NCAR / VAPOR

VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers
https://www.vapor.ucar.edu/
Other
173 stars 49 forks source link

Use DataMgrUtils instead of CE #3608

Closed sgpearse closed 2 weeks ago

sgpearse commented 1 month ago

@stasj, I looked into using RenderParams to query a random 3D variable but there does not seem to be a way to do this. The RenderParams gets instantiated with a dimensionality, and has no evident way to query variables outside of their given dimension. The only path forward I found was to use DataMgrUtils, shown here.

Also, the CE method used in PR #3584 does in fact find the domain extents by taking the union of all variables in the dataset. Not taking the union of the extents could break the PRegionSelector if we don't land on a variable that encloses the entire domain, which could happen. WRF can contain soil and fire grids that lie outside or within the meteorological grids that we typically deal with.

Feel free to pick whichever solution you like.

Fixes #3575 and #3583.

sgpearse commented 3 weeks ago

@stasj I chose to return from functions that were VAsserting when the texture size was too small. I don't think it's necessary to report an error to the user when the shrink the region to something that won't render anything.