search

NCAR / ccpp-doc

Technical Documentation for the Common Community Physics Package (CCPP)
0 stars 33 forks source link

Update doc to include [ccpp-table-properties]: #28

Closed JulieSchramm closed 4 years ago

JulieSchramm commented 4 years ago
JulieSchramm commented 4 years ago

Here is the PDF file. See Chapter 3.

CCPPtechnical.pdf

climbfuji commented 4 years ago

Here is the PDF file. See Chapter 3.

CCPPtechnical.pdf

Thanks. It looks good to me. In the third paragraph of chapter three, we speak about GFS_physics_driver.F90 etc in a context that includes both SCM and the UFS. These files, however, only exist (yes, they still do) in the UFS, not in the SCM. But maybe we don't need to be that picky.

JulieSchramm commented 4 years ago

I saw this sentence and wasn't sure if these files were still used. They still exist in the UFS model. Do you have a suggestion on how to edit the wording?

On Thu, Oct 15, 2020 at 1:30 PM Dom Heinzeller notifications@github.com wrote:

@climbfuji approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/28#pullrequestreview-509701892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WNU3QSUN2SSICP46QDLTSK5EUPANCNFSM4SSJSRKA .

climbfuji commented 4 years ago

Leave it for now, is my suggestion. They will be gone in a month time, and then we have to rewrite the paragraph anyway.

On Oct 15, 2020, at 1:37 PM, JulieSchramm notifications@github.com wrote:

I saw this sentence and wasn't sure if these files were still used. They still exist in the UFS model. Do you have a suggestion on how to edit the wording?

On Thu, Oct 15, 2020 at 1:30 PM Dom Heinzeller notifications@github.com wrote:

@climbfuji approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/28#pullrequestreview-509701892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WNU3QSUN2SSICP46QDLTSK5EUPANCNFSM4SSJSRKA .

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/28#issuecomment-709547450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RP4PITM5YXNPZTLUBLSK5FOVANCNFSM4SSJSRKA.

JulieSchramm commented 4 years ago

Can this be merged? I resolved the two paragraphs using the GitHub page. I'm not sure about what to do about the links on page 2. I don't want the links to create a merge conflict every time we have to merge a release branch back to master.