search

NCAR / ccpp-doc

Technical Documentation for the Common Community Physics Package (CCPP)
0 stars 33 forks source link

Feature/update v5 Updates for CCPP v5.0 release #36

Closed JulieSchramm closed 3 years ago

JulieSchramm commented 3 years ago

html and pdf builds are successful CCPPtechnical.pdf

ligiabernardet commented 3 years ago

I will review your changes as soon as time allows. I believe it is fine to remove no_nsst. The only caveat is that for CCPP v6 we may have to reintroduce it all back in for use with UFS MRW App. However, I do not have a better course of action to propose.

ligiabernardet commented 3 years ago

Please find all instances of gmtb-help@ucar.edu and replace them with references to the Forums (CCPP Forum and UFS WM Forum). The helpdesk has been deactivated.

If the focus is on RRFS, it is best to use FV3_RRFS_v1alpha than GFSv15p2, since FV3_RRFS_v1alpha is the primary suite for RRFS. However, it is also fine to use a suite that works with the SCM, such as GFSv16beta (but use the SCM one, not the FV3 one).

On Tue, Jan 5, 2021 at 8:30 AM JulieSchramm notifications@github.com wrote:

@JulieSchramm commented on this pull request.

In CCPPtechnical/source/ConstructingSuite.rst https://github.com/NCAR/ccpp-doc/pull/36#discussion_r552005147:

@@ -151,22 +151,17 @@ Consider the case where a model requires that some subset of physics be called o

-GFS v16beta Suite +RRFS v1beta Suite

"Please all instances of gmtb-help@ucar.edu" This needs a verb. Suites FV3_GFS_v15p2 and FV3_RRFS_v1alpha are supported for the SRW App release v1, should we be using one of these?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/36#discussion_r552005147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7WQAXYM33EM2AL2NPOVDTSYMWCJANCNFSM4VNNVIQA .

JulieSchramm commented 3 years ago

My questions were not addressed.

On Tue, Jan 5, 2021 at 8:40 AM ligiabernardet notifications@github.com wrote:

Please all instances of gmtb-help@ucar.edu and replace them with references to the Forums (CCPP Forum and UFS WM Forum). The helpdesk has been deactivated.

If the focus is on RRFS, it is best to use FV3_RRFS_v1alpha than GFSv15p2, since FV3_RRFS_v1alpha is the primary suite for RRFS. However, it is also fine to use a suite that works with the SCM, such as GFSv16beta (but use the SCM one, not the FV3 one).

On Tue, Jan 5, 2021 at 8:30 AM JulieSchramm notifications@github.com wrote:

@JulieSchramm commented on this pull request.

In CCPPtechnical/source/ConstructingSuite.rst https://github.com/NCAR/ccpp-doc/pull/36#discussion_r552005147:

@@ -151,22 +151,17 @@ Consider the case where a model requires that some subset of physics be called o

-GFS v16beta Suite +RRFS v1beta Suite

"Please all instances of gmtb-help@ucar.edu" This needs a verb. Suites FV3_GFS_v15p2 and FV3_RRFS_v1alpha are supported for the SRW App release v1, should we be using one of these?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/36#discussion_r552005147, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AE7WQAXYM33EM2AL2NPOVDTSYMWCJANCNFSM4VNNVIQA

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-doc/pull/36#issuecomment-754714256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WNU3JCKM63NHKGFMO4C3SYMXGLANCNFSM4VNNVIQA .

ligiabernardet commented 3 years ago

With verb: Please find all instances of gmtb-help@ucar.edu and replace them with references to the Forums (CCPP Forum and UFS WM Forum). The helpdesk has been deactivated.

To reduce the number of changes, I'd stick with SCM_GFSv16beta. But it is also totally fine to use FV3_RRFS_v1alpha.

If this does not answer your questions, please restate.