search

NCAR / ccpp-doc

Technical Documentation for the Common Community Physics Package (CCPP)
0 stars 33 forks source link

Documentation for new 3D diagnostic tendencies #38

Closed SamuelTrahanNOAA closed 3 years ago

SamuelTrahanNOAA commented 3 years ago

The "develop" and "main" branches of UFS, FV3, and ccpp/physics now support 3D diagnostic tendencies for tracers. This PR updates the documentation to match the new method.

Edit July 20, 2021: The code is now in the "main" and "develop" branches, so this PR contains documentation for the latest code.

Changes written by @SamuelTrahanNOAA by request of @ligiabernardet and @climbfuji

Code PRs are here:

https://github.com/NOAA-EMC/fv3atm/pull/332 https://github.com/NCAR/ccpp-physics/pull/681 https://github.com/ufs-community/ufs-weather-model/pull/660

SamuelTrahanNOAA commented 3 years ago

I'm uncertain of the SCM aspects of the documentation, so I'm hoping others can comment on that in their reviews.

ligiabernardet commented 3 years ago

It is good to review this PR, but it should only be merged when the code changes themselves go to master.

SamuelTrahanNOAA commented 3 years ago

Thank you so much for documenting this capability. It is quite easy to follow.

Hopefully it is still easy to follow now that I've rearranged it.

SamuelTrahanNOAA commented 3 years ago

Can this PR be merged now? The code PRs are all merged to their respective central repositories.