search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Run Travis on all forks? #401

Closed gold2718 closed 11 months ago

gold2718 commented 3 years ago

Currently, the Travis CI workflow is run in any fork on any push. I feel this should be restricted to the main repo (NCAR/ccpp-framework), especially since git encourages frequent commits and currently a failure sends email to several (not involved for a fork push) parties. @climbfuji, @JulieSchramm, Thoughts?

climbfuji commented 3 years ago

Fine by me. Julie, since you added those tests, do you want to change the CI tests so that they only run for NCAR/ccpp-framework?

JulieSchramm commented 3 years ago

I've hacked at this for a day without success, so maybe someone who is more familiar with Travis CI can take a look at it.

climbfuji commented 1 year ago

Is this still an issue? We are using github actions nowadays, and those run fine everywhere. I do recommend however to change

https://github.com/NCAR/ccpp-framework/blob/3a8f27885f680251653b72d9c86ecfd96de23b06/.github/workflows/python.yaml#L3

to

on:
  pull_request:
    paths-ignore:
      - 'doc/**'
      - '**.md'
      - '.github/ISSUE_TEMPLATE/*'
      - '.gitignore'

(or whatever the exact exclusion list should be)

climbfuji commented 1 year ago

@mkavulich @peverwhee @dustinswales

dustinswales commented 1 year ago

@climbfuji I think we can close this In #494 this is changed to trigger on PRs. Do we need to add paths-ignore?

climbfuji commented 1 year ago

paths-ignore just means that you don't run CI tests if you are only changing documentation (it still runs doxygen etc), README.md etc. Whatever you list there. Makes sense, or?

dustinswales commented 1 year ago

Gotcha. Then yes, lets add these exclusions to #494, and reference this Issue?

climbfuji commented 1 year ago

Sounds good to me

On Sep 14, 2023, at 2:01 PM, Dustin Swales @.***> wrote:

Gotcha. Then yes, lets add these exclusions to #494 https://github.com/NCAR/ccpp-framework/pull/494, and reference this Issue?

— Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-framework/issues/401#issuecomment-1720063440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RNE4P3KZ4V7MLXBPADX2NPA7ANCNFSM5C53A4GA. You are receiving this because you were mentioned.

climbfuji commented 11 months ago

Closed via https://github.com/NCAR/ccpp-framework/pull/494