feature/capgen: CI tests failing after latest merge (11/01)

[climbfuji]

Description

Run export PYTHONPATH=$(pwd)/scripts:$(pwd)/scripts/parse_tools
8
F...                                                                     [100%]
9
=================================== FAILURES ===================================
10
________________________ test_MetadataTable_parse_table ________________________
11

12
tmpdir = local('/tmp/pytest-of-runner/pytest-0/test_MetadataTable_parse_table0')
13

14
    def test_MetadataTable_parse_table(tmpdir):
15
        path = str(tmpdir.join("table.meta"))
16
        with open(path, "w") as f:
17
            f.write(example_table)
18

19
        metadata_headers = parse_metadata_file(path, known_ddts=registered_fortran_ddt_names(),
20
>                                                           logger=logging.getLogger(__name__))
21
E       TypeError: parse_metadata_file() got an unexpected keyword argument 'logger'
22

23
tests/test_metadata_parser.py:36: TypeError

I will try to find time to fix this later today or tomorrow.

[gold2718]

I do not know anything about these CI tests. Why are there "CI" tests that are separate from the tests and unit tests we implemented as a group? What are they for?

[climbfuji]

Didn't Julie add those a while back?

On Nov 1, 2021, at 1:58 PM, goldy @.***> wrote:

I do not know anything about these CI tests. Why are there "CI" tests that are separate from the tests and unit tests we implemented as a group? What are they for?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-framework/issues/411#issuecomment-956543005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RMAA5MSI5M657E6RTTUJ3WNPANCNFSM5HEZC2EA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[climbfuji]

But don't worry, I will take a look later today after my meetings.

On Nov 1, 2021, at 1:58 PM, Dom Heinzeller @.***> wrote:

Didn't Julie add those a while back?

On Nov 1, 2021, at 1:58 PM, goldy @. @.>> wrote:

I do not know anything about these CI tests. Why are there "CI" tests that are separate from the tests and unit tests we implemented as a group? What are they for?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NCAR/ccpp-framework/issues/411#issuecomment-956543005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RMAA5MSI5M657E6RTTUJ3WNPANCNFSM5HEZC2EA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[gold2718]

Not worried, just curious. The log for that file just shows you and Noah D. Brenowitz nbren12@gmail.com (not sure who that is).

[climbfuji]

Closed via https://github.com/NCAR/ccpp-framework/pull/412.