search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Update main from feature/capgen following the refactoring and implementation of strict metadata units checking #416

Closed climbfuji closed 2 years ago

climbfuji commented 2 years ago

Description

With the metadata parser update in the refactoring update of the feature/capgen branch (https://github.com/NCAR/ccpp-framework/pull/410), a stricter checking of units is enforced. This includes the replacement of "convenience units" such as log(Pa) with 1. Afterwards, feature/capgen was updated from main (https://github.com/NCAR/ccpp-framework/pull/414).

Now feature/capgen needs to be merged back into main so that the strict unit checking will be enabled for NCAR ccpp-physics main, fv3atm and ccpp-scm.

Solution

Update main from feature/capgen and fix invalid units.