search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Major cleanup of cmake build config, contains "Remove Laurie from CODEOWNERS" (#421) #420

Closed climbfuji closed 2 years ago

climbfuji commented 2 years ago

This PR is a major cleanup of the cmake build config, including removing legacy cmake modules that are no longer required. A follow-up or parallel PR will be require for CCPP-SCM to adjust to these build config changes.

This PR is related to issue https://github.com/ufs-community/ufs-weather-model/issues/945.

PR https://github.com/NCAR/ccpp-framework/pull/421 (Remove Laurie from CODEOWNERS) was pulled into this PR.

Associated PRs:

https://github.com/NCAR/ccpp-framework/pull/420 https://github.com/NCAR/ccpp-physics/pull/792 https://github.com/NOAA-EMC/fv3atm/pull/436 https://github.com/ufs-community/ufs-weather-model/pull/943

For regression testing with the UFS, see https://github.com/ufs-community/ufs-weather-model/pull/943.

gold2718 commented 2 years ago

Is there an issue for this PR? There is a self-referential "associated" PR link but no open issue as described in the CCPP Framework Development Workflow.

climbfuji commented 2 years ago

Is there an issue for this PR? There is a self-referential "associated" PR link but no open issue as described in the CCPP Framework Development Workflow.

That was an oversight. This PR is related to issue https://github.com/ufs-community/ufs-weather-model/issues/945, I updated the PR description accordingly. Thanks for pointing this out.