Merge feature/capgen into main and correct standard name and unit of CCPP metadata for error flag variable in the prebuild scripts, as well as the unit of ccpp_constant_one in the prebuild scripts.
Merging feature/capgen into main removes a workaround in the capgen metadata parser (parse checker) that was used in main only. Without the workaround, a mismatch of the unit of ccpp_constant_one is now an error.
Also: capgen.py uses ccpp_error_code with unit 1 instead of ccpp_error_flag with unit flag. This PR changes the ccpp_prebuild.py side to follow what capgen is doing.
User interface changes?: No (for the ccpp-framework side), yes for existing schemes in NCAR ccpp-physics main. Need to update standard name and unit of the CCPP error flag variable
Merge feature/capgen into main and correct standard name and unit of CCPP metadata for error flag variable in the prebuild scripts, as well as the unit of
ccpp_constant_onein the prebuild scripts.Merging feature/capgen into main removes a workaround in the capgen metadata parser (parse checker) that was used in main only. Without the workaround, a mismatch of the unit of
ccpp_constant_oneis now an error.Also:
capgen.pyusesccpp_error_codewith unit1instead ofccpp_error_flagwith unitflag. This PR changes theccpp_prebuild.pyside to follow whatcapgenis doing.User interface changes?: No (for the ccpp-framework side), yes for existing schemes in NCAR ccpp-physics main. Need to update standard name and unit of the CCPP error flag variable
Fixes https://github.com/NCAR/ccpp-framework/issues/397.
Testing: test removed: none unit/system tests: capgen tests (
tests/run_test.sh) pass regression testing: see https://github.com/ufs-community/ufs-weather-model/pull/1013Associated PRs:
https://github.com/NCAR/ccpp-framework/pull/428 https://github.com/NCAR/ccpp-physics/pull/828 https://github.com/NOAA-EMC/fv3atm/pull/467 https://github.com/ufs-community/ufs-weather-model/pull/1013