search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Remove legacy src/ccpp_api.F90 - contains #445 (fix metadata2html.py) and #447 (remove NEMSfv3gfs test scripts) #443

Closed climbfuji closed 2 years ago

climbfuji commented 2 years ago

Remove legacy src/ccpp_api.F90.

Note. This PR now (04/10/2022) also contains the changes from #445 and #447 (all approved).

User interface changes? Yes

Models currently importing ccpp_t from ccpp_api must get it from ccpp_types directly.

Fixes https://github.com/NCAR/ccpp-framework/issues/442

Testing:

I ran the two tests that Julie set up a while back for ccpp_prebuild.py in directory tests, both of them passed:

> PYTHONPATH=/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts/parse_tools:/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts:$PYTHONPATH python3 test_metadata_parser.py
> PYTHONPATH=/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts/parse_tools:/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts:$PYTHONPATH python3 test_mkstatic.py

The change is also being tested by the ufs-weather-model regression testing system, see https://github.com/ufs-community/ufs-weather-model/pull/1130