Closed climbfuji closed 2 years ago
Remove legacy src/ccpp_api.F90.
src/ccpp_api.F90
Note. This PR now (04/10/2022) also contains the changes from #445 and #447 (all approved).
User interface changes? Yes
Models currently importing ccpp_t from ccpp_api must get it from ccpp_types directly.
ccpp_t
ccpp_api
ccpp_types
Fixes https://github.com/NCAR/ccpp-framework/issues/442
Testing:
I ran the two tests that Julie set up a while back for ccpp_prebuild.py in directory tests, both of them passed:
ccpp_prebuild.py
tests
> PYTHONPATH=/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts/parse_tools:/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts:$PYTHONPATH python3 test_metadata_parser.py > PYTHONPATH=/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts/parse_tools:/Users/dom.heinzeller/scratch/ufs-weather-model/ufs-weather-model-split-gfs-typedefs/FV3/ccpp/framework/scripts:$PYTHONPATH python3 test_mkstatic.py
The change is also being tested by the ufs-weather-model regression testing system, see https://github.com/ufs-community/ufs-weather-model/pull/1130
Remove legacy
src/ccpp_api.F90
.Note. This PR now (04/10/2022) also contains the changes from #445 and #447 (all approved).
User interface changes? Yes
Models currently importing
ccpp_t
fromccpp_api
must get it fromccpp_types
directly.Fixes https://github.com/NCAR/ccpp-framework/issues/442
Testing:
I ran the two tests that Julie set up a while back for
ccpp_prebuild.py
in directorytests
, both of them passed:The change is also being tested by the ufs-weather-model regression testing system, see https://github.com/ufs-community/ufs-weather-model/pull/1130