Update `authors` in `CMakeLists.txt`

NCAR / ccpp-framework

Common Community Physics Package (CCPP)

http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/

Other

26 stars 63 forks source link

Update `authors` in `CMakeLists.txt` #448

Closed climbfuji closed 4 months ago

climbfuji commented 2 years ago

Guess it's time to update authors in the top-level CMakeLists.txt (and potentially other CMakeLists.txt files in subdirectories).

https://github.com/NCAR/ccpp-framework/blob/e200083f2503106541349d1af130f98c72047e11/CMakeLists.txt#L10

climbfuji commented 8 months ago

@dustinswales @gold2718 @peverwhee Should this list be the same as what's in CODEOWNERS, or a subset/superset of it?

dustinswales commented 8 months ago

I updated the authors in #504. @gold2718 Do you want to still be on this list?

gold2718 commented 8 months ago

I updated the authors in #504. @gold2718 Do you want to still be on this list?

I guess it depends on the purpose of the variable but I would say yes.

It would be useful as a point of contact (but then, an email or GitHub ID would be a useful addition).
For "who to blame when something goes wrong", I still have plenty of fingerprints in the code.
For posterity, well, then, we should never remove any authors (e.g., https://earthsystemmodeling.org/docs/release/latest/ESMF_usrdoc/).

climbfuji commented 7 months ago

Based on the comments above, can we add Steve back in https://github.com/NCAR/ccpp-framework/pull/504/files --> CMakeLists.txt in exchange for a review and approval, so that we can move ahead (and close this issue as done)?

dustinswales commented 4 months ago

Addressed in #504

gold2718 commented 4 months ago

I'm not sure what the final decision was but comparing the result with 'git blame', we have: ~Steve Goldhaber: 23675 (2023)~ ~Julie Schramm: 14792 (2021)~ Dom Heinzeller: 12455 (2024) Courtney Peverley: 4566 (2024) Dustin Swales: 785 (2024) Michael Kavulich, Jr: 357 (2024) ~Laurie Carson: 2225 (2021)~ ~Timothy Brown: 146 (2017)~ ~Noah D. Brenowitz: 54 (2021)~ Grant Firl: 66 (2024) ~Ufuk Turuncoglu: 23 (2022)~ ~Dusan Jovic: 22 (2024)~ ~John Michalakes: 14 (2023)~ ~Michael Waxmonsky: 6 (2023)~ ~Cheryl Craig: 3 (2020)~ ~Dave Gill: 1 (2017)~ ~Man Zhang: 1 (2020)~

where the number after the colon is the number of lines of code shown by git blame and the year of last contribution is shown in parentheses. Data as of commit 011db4f80a02cba6d65958ace56e8efb197be62b.