NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 63 forks source link

Limit suite names to 37 characters or less #455

Closed mkavulich closed 1 year ago

mkavulich commented 1 year ago

Per discussion on #337, this implements a hard cap on suite names of 37 characters for ccpp_prebuild.

User interface changes?: [ Yes ] If a user attempts to run ccpp_prebuild with a suite name longer than 37 characters, prebuild will fail with an error message indicating the problem.

Fixes: Part of #337 (ccpp_prebuild only)

Testing: test removed: unit tests: system tests: manual testing: Ran ccpp_prebuild.py both stand-alone and for SCM, script ran successfully for existing suites, and failed as expected when a new long suite name was introduced. Will run more tests if requested.