Capgen cleanup - Githubissues

NCAR / ccpp-framework

Common Community Physics Package (CCPP)

http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/

Other

26 stars 63 forks source link

Capgen cleanup #493

Closed peverwhee closed 9 months ago

peverwhee commented 11 months ago

Summary

This PR contains mostly clean-up for readability and clarity.

Description

Update CODEOWNERS file
Add optional database object output for capgen
Code cleanup

User interface changes?: Yes Can now include optional return_db argument to capgen to return a database for use by host model.

Addresses #380

Testing: All tests passing except for unit conversion test that is expected to fail.

mkavulich commented 10 months ago

RE: python2 I'm pretty sure python 2 support was de-facto ended long ago (there are a lot of python-3 specific constructs like f-strings deep in the framework, and have been there for more than a year). I'm not sure that requires any specific notes.

climbfuji commented 9 months ago

@peverwhee @nusbaume This has been approved by a bunch of people. @nusbaume Can you look at your previous comments and approve if ok, so that we can merge this? Thanks!