NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 63 forks source link

Constituents #495

Closed peverwhee closed 8 months ago

peverwhee commented 11 months ago

Summary

Updates to bring in constituents object and constituent properties object.

Description

User interface changes?: Yes Can now optionally add constituent via metadata property advected=True

Addresses #282

Testing:

dustinswales commented 10 months ago

@peverwhee Can you update this branch with updates from feature/capgen?

gold2718 commented 8 months ago

My only real concern is the newly added debug_on feature

I second this. I think the name probably came from the name of the logging level but it is certainly verbose!

climbfuji commented 8 months ago

@peverwhee We were wondering in our tag up today when/if you were planning to make the debug_on() --> verbose() change so that we can approve and merge?

peverwhee commented 8 months ago

@climbfuji Yes! I will try to finish up addressing the remaining comments tomorrow.