NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Add check to disallow usage of horizontal_dimension in the run phase #521

Open peverwhee opened 9 months ago

peverwhee commented 9 months ago

Description

There is currently no check that disallows usage of horizontal_dimension in the run phase of a physics scheme (where horizontal_loop_extent must be used).

Steps to Reproduce

  1. Check out the head of feature/capgen
  2. Attempt to run with a physics scheme (or modify an existing test scheme) that uses horizontal_dimension in the run phase in the metadata
  3. See that it compiles without error.

Additional Context

The framework will currently error if you try to use horizontal_loop_extent outside of the run phase, so it should be updated to error when you try to misuse horizontal_dimension as well.