search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 62 forks source link

Dummy-allocate inactive local variables #536

Closed grantfirl closed 4 months ago

grantfirl commented 4 months ago

Allocate dummy inactive local variables to size 0.

This is a temporary fix for the RRFS branch that is needed to compile with -check all. Using this flag, even if variables are not used within a scheme, they are checked for their allocation status, and unallocated variables lead to a runtime error. This fix goes with the other temporary fixes in ccpp-physics, fv3atm, etc. for the RRFS branch only. This issue is address more completely via https://github.com/NCAR/ccpp-framework/pull/529, and will be pulled into main when ready.

User interface changes?: No

Fixes: temporarily addresses https://github.com/ufs-community/ufs-weather-model/issues/2023

Testing: test removed: unit tests: system tests: See https://github.com/ufs-community/ufs-weather-model/pull/2158 for testing results. manual testing:

jkbk2004 commented 4 months ago

@dustinswales @grantfirl tests are done at https://github.com/ufs-community/ufs-weather-model/pull/2158. Can you merge this pr?