NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Bug fix for chunked array support in ccpp_prebuild #538

Closed climbfuji closed 8 months ago

climbfuji commented 8 months ago

Small bug fix required to use chunked arrays and retain backward compatibility with blocked data structures in ccpp_prebuild.py

This PR is a small bug fix in order to provide backward compatibility with blocked data structures. Specifically, we need to check if the host model variable is a contiguous array (it's horizontal dimension is CCPP_HORIZONTAL_DIMENSION) or part of a blocked data structure (it's horizontal dimension is CCPP_HORIZONTAL_LOOP_EXTENT).

User interface changes?: No

Resolves https://github.com/NCAR/ccpp-framework/issues/539

Testing:

Dependencies/associated PRs:

This is part of a set of (independent) PRs:

climbfuji commented 8 months ago

Does this work if you have 'chunked' data but only one chunk? I don't see why it shouldn't but wondered if this is something you test.

Yes, it works in that case, too. Thanks for the quick review!

climbfuji commented 8 months ago

@grantfirl UFS testing for this PR is complete. Can you add your final review please and merge if ok? Thanks!

zach1221 commented 8 months ago

Good morning, @grantfirl . Testing is complete on UFS-WM PR #2164. Can you please merge this PR for us?