NCAR / ccpp-framework

Common Community Physics Package (CCPP)

http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/

Other

26 stars 62 forks source link

bugfixes for multiple groups and scalar variable transforms #542

Closed peverwhee closed 4 months ago

peverwhee commented 4 months ago

Description

Updates to enable more than one scheme group, and also enable unit transforms for scalar (non-dimensioned) variables.

Updated Files

Groups:

ccpp_suite.py - don't promote loop variables to suite level
host_cap.py - fix for iterating over suite part list
suite_objects.py - check if variable is at suite level before giving up hope and throwing an error

Scalar transforms:

suite_objects.py - don't try to do vertical dimension transform for scalar variable; conditionally write comments for var transform calls
var_props.py - don't include parenthesis (e.g. variable1() = 2 * variable2()) for scalar variable transforms

Misc:

metavar.py - fix for bug surely introduced by me converting to fstrings at some point

User interface changes?: No

Testing: test removed: unit tests: system tests: modified capgen_test to include multiple groups manual testing:

climbfuji commented 4 months ago

I'll go ahead and merge this, then we can update the other open capgen PR (#529) for which the discussion is still ongoing.