search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Add openmpi install to CI #551

Closed dustinswales closed 6 months ago

dustinswales commented 6 months ago

This PR adds to the CCPP Prebuild CI test to install open-mpi v4.1.6, which is now a requirement for CCPP.

dustinswales commented 6 months ago

@grantfirl @mkavulich @scrasmussen Just a heads up. When the CCPP SCM updates its CCPP Framework hash, all of the CI tests will break until this addition is added to those tests.

climbfuji commented 6 months ago

That's great! I know this is pedantic but we'll probably want to include that in one of the upcoming ufs prs, even though this clearly doesn't affect anything but CI.

dustinswales commented 6 months ago

@mkavulich This should not have been merged into main. All PRs targeting the main branch need to go through host model testing before getting the okay to merge.

climbfuji commented 6 months ago

I created https://github.com/ufs-community/ufs-weather-model/issues/2216 to include this change. No need to roll back I think because this PR shouldn't affect anything in the UFS. But let's try to avoid merging into main w/o full testing (see also @peverwhee's issue about creating a develop branch with a smaller testing harness)