Cleanup, adding unit tests for `ccpp_track_variables.py`, activate "chunked data" CI test, add missing MPI target in src/CMakeLists.txt

mkavulich commented 3 months ago

This PR makes several related changes:

Add unit tests for the ccpp_track_variables.py script, and run them automatically in CI, as requested in #511. In addition, some cleanup changes were made to ccpp_track_variables.py to make implementing the CI test easier.
In implementing these new CI tests, I realized that the new "chunked_data" CI tests were not actually run; this PR will activate them.
Finally, there was a single change to ccpp_prebuild.py to make the import_config() routine fail "correctly" when the config file is not present: previous behavior was an exception due to mismatched return values.

User interface changes?: No

Fixes: #511

Testing: test removed: None unit tests: Adds test_track_variables.py to CI. Also, activates system tests: I am not sure what this means 🤷 manual testing: Ran new tests manually with pytest

mkavulich commented 2 months ago

@climbfuji @gold2718 I agree we should have some docstrings here before merge, I'll work on that today.

mkavulich commented 2 months ago

@climbfuji @gold2718 I have added the requested docstrings, as well as updating the existing file-level docstring and adding a call to sys.exit() for the case where the test is not run with pytest. Let me know if you'd like any further changes/updates.

mkavulich commented 2 months ago

@climbfuji @mwaxmonsky Thanks for the reviews, I have adopted your suggested changes.

grantfirl commented 2 months ago

@mkavulich Can you pull #556 into this so that I can add the latest hash of this branch to https://github.com/NOAA-EMC/fv3atm/pull/816.

mkavulich commented 2 months ago

@grantfirl Done

NCAR / ccpp-framework

Cleanup, adding unit tests for `ccpp_track_variables.py`, activate "chunked data" CI test, add missing MPI target in src/CMakeLists.txt #555