NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Update CI to use more GNU versons with Capgen tests/ #563

Closed dustinswales closed 4 months ago

dustinswales commented 4 months ago

Expand CI to use multiple GNU fortran compilers

Please Note: Our CI tests use ubuntu-latest, which is v22.04, but soon this will be v24.04, which has GNU 14, but not GNU 9, 10, 11. If we want these 5 GNU tests to work w/o interruption, we should change ubuntu-latest to ubuntu-22.04. If we want to use GNUv14, we could add another script that uses ubuntu-latest(24.04). Or extend this script to use both. Just something to keep in mind.

mkavulich commented 4 months ago

RE: the ubuntu version, I like the idea of having a static Ubuntu 22 that still allows for older GNU compilers and adding a new Ubuntu 24 test for the newer compilers. Until fairly recently the default GNU compiler on Hera was 9.2.0, and I assume there will still be many in the community still using GNU 10 and 11 for some time. And it looks like Ubuntu 22 is still supported for 3 more years.

climbfuji commented 4 months ago

Should we combine this PR with the opt-arg PR set for the ufs?

dustinswales commented 4 months ago

@mwaxmonsky There seems to be inconsistencies in what is listed as available for 22.04 and 24.04? In our tests, 22.04 has GNU9-12, but it should be 10-12? And the 24.04 OS is not working at all?

Not sure what's going on, but I'm going to turn off the 24.04 tests for now and PR this into #552. @DomHeinzeller Sound good?

climbfuji commented 4 months ago

Yes please - just do 22.04 for now. It's always better to hardcode the runner, they make so many updates and one never notices. Thanks!

mwaxmonsky commented 4 months ago

@mwaxmonsky There seems to be inconsistencies in what is listed as available for 22.04 and 24.04? In our tests, 22.04 has GNU9-12, but it should be 10-12? And the 24.04 OS is not working at all?

Not sure what's going on, but I'm going to turn off the 24.04 tests for now and PR this into #552. @DomHeinzeller Sound good?

Darn. Was hoping those would be simple drop ins for testing. Noticed some grumblings online about 24.04 recently but didn't think they'd impact gfortran. Might have to wait a bit for 24.04 testing. :(

dustinswales commented 4 months ago

@mwaxmonsky There seems to be inconsistencies in what is listed as available for 22.04 and 24.04? In our tests, 22.04 has GNU9-12, but it should be 10-12? And the 24.04 OS is not working at all? Not sure what's going on, but I'm going to turn off the 24.04 tests for now and PR this into #552. @DomHeinzeller Sound good?

Darn. Was hoping those would be simple drop ins for testing. Noticed some grumblings online about 24.04 recently but didn't think they'd impact gfortran. Might have to wait a bit for 24.04 testing. :(

Yeah, 24.04 dropped two days ago, so it's super green and apparently some issues need to be worked through.

dustinswales commented 4 months ago

Merged in #552