search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Standardize ordering of ccpp_error_code and ccpp_error_message #574

Open peverwhee opened 3 months ago

peverwhee commented 3 months ago

Description

The framework sometimes uses "errcode, errmsg" in the calling list and sometimes has "errmsg, errcode". It would be nice if this was consistent.

The NCAR SEs are leaning towards "errcode, errmsg", but are happy either way.

Solution

Modify all calling lists (in generated code and in static src code) to adhere to ordering we decide.

climbfuji commented 3 months ago

In the UFS, it's consistently errmsg, errflg

Example: https://github.com/ufs-community/ccpp-physics/blob/ufs/dev/physics/CONV/Grell_Freitas/cu_gf_driver.F90

peverwhee commented 3 months ago

@DomHeinzeller OK, sounds like it'll be easiest to keep it in that order for the framework then. That's fine by me!