NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Add constituent tendency capability #584

Closed peverwhee closed 2 weeks ago

peverwhee commented 3 months ago

Summary Adds constituent tendency array and enables the use of individual constituent tendency variables.

Description In order to facilitate time-splitting, this PR adds/enables the following:

User interface changes?: Yes, but optional User can now use the following in scheme metadata:

Testing: test removed: None unit tests: Added doctests to new check_tendency_variables function in host_cap.F90 system tests: Modified advection_test to use tendency variable and tendency array manual testing: Updates run in CAM-SIMA

climbfuji commented 1 month ago

@peverwhee Please re-request a review from all the reviewers once you've addressed the questions/concerns from @mwaxmonsky and @dustinswales (I keep coming back to re-review but then remind myself that there are still comments that need to be addressed). Thank you!

climbfuji commented 3 weeks ago

@peverwhee Can you please update the branch from develop? There are merge conflicts that need to be resolved. Thanks!

peverwhee commented 3 weeks ago

@DomHeinzeller done!

I think I'll give @gold2718 a bit more time if he'd still like to review this before merging. Say, by next wednesday (11/6)?