search

NCAR / ccpp-framework

Common Community Physics Package (CCPP)
http://www.dtcenter.org/community-code/common-community-physics-package-ccpp/
Other
26 stars 64 forks source link

Constituent bugfixes #608

Closed peverwhee closed 2 weeks ago

peverwhee commented 3 weeks ago

Fixes a couple of small bugs in the constituents object

  1. Add missing units field to equivalence check and constituent copy
  2. Add missing fields to instantiate call
  3. Parse mixing ratio type from standard name correctly (if "mixing_ratio_type" not provided to instantiate)
  4. Add check of errflg in register to return before allocating if there's an error

User interface changes?: No

Fixes #587

Testing: test removed: N/A unit tests: All pass system tests: All pass; modified advection test to check new instantiate fields manual testing: Run w/ register phase in CAM-SIMA

climbfuji commented 3 weeks ago

I approve (still no "approve" button on my machine)